perf(releases): Batch CommitAuthor queries in set_commits #106318
Merged
+140
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace N+1 get_or_create queries with batch operations: - Batch fetch existing authors with single filter(email__in=...) - Batch create missing authors with bulk_create(ignore_conflicts=True) - Batch update changed names with bulk_update Reduces query count from 2N+ to at most 4 queries regardless of author count, significantly improving performance for releases with many unique commit authors. Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
the
Scope: Backend
shashjar
approved these changes
Jan 15, 2026
| data["_normalized_email"] = author_email | ||
|
|
||
| if author_email and author_email not in author_data_by_email: | ||
| author_data_by_email[author_email] = {"name": data.get("author_name")} |
Member
There was a problem hiding this comment.
Can the above section be compressed into the below?
author_email = truncatechars(author_email, 75)
if author_email:
# Lowercase to match CommitAuthorManager.get_or_create behavior
author_email = author_email.lower()
# Store normalized email back in data for later lookup
data["_normalized_email"] = author_email
if author_email not in author_data_by_email:
author_data_by_email[author_email] = {"name": data.get("author_name")}
| ) | ||
|
|
||
|
|
||
| def create_commit_authors(commit_list, release): |
Member
There was a problem hiding this comment.
Up to you but worth adding a test to verify the batching behavior or anything else related to commit authors?
- Simplify code by moving _normalized_email assignment inside if block - Add test_multiple_authors to verify batch author creation, reuse, and name updates Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace N+1 get_or_create queries with batch operations:
Reduces query count from 2N+ to at most 4 queries regardless of author count, improving performance for releases with many unique commit authors.
n+1 issue
https://sentry.sentry.io/issues/6234355863/